Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign VSMCards component #219

Closed
6 tasks done
Tracked by #159
SjoenH opened this issue Oct 5, 2021 · 22 comments
Closed
6 tasks done
Tracked by #159

Redesign VSMCards component #219

SjoenH opened this issue Oct 5, 2021 · 22 comments
Assignees
Labels
front-end Frontend code, functionality, or client-side interactions

Comments

@SjoenH
Copy link
Contributor

SjoenH commented Oct 5, 2021

image

  • Move the edited time text up.
  • Update userDots component to only show 3 users at a time.
  • Make the userdots component clickable. ⇾ open AccessBox- component in a scrim. Center on the page.
  • Create new Label-component
  • Create new Labels-component. Display a maximum of 10 labels at a time. Show them all.
  • show the whole title for a card. No truncation. Wrap down to new-line.

These changes should cover #216. So remember to close that one after this is done.

@SjoenH SjoenH mentioned this issue Oct 5, 2021
28 tasks
@SjoenH SjoenH added front-end Frontend code, functionality, or client-side interactions duplicate labels Oct 5, 2021
@martabenthem
Copy link
Contributor

@knudsvik
Copy link
Contributor

knudsvik commented Oct 7, 2021

As of today, the titles on the cards are truncated without any visual indications of it being truncated. There should be a visual indication, e.g. ... and possibility to see the full title when hovering

@SjoenH
Copy link
Contributor Author

SjoenH commented Oct 8, 2021

@knudsvik 👋
@Linedueo suggests that we show the whole title for a card. No truncation. Wrap down to new-line.

@SjoenH
Copy link
Contributor Author

SjoenH commented Oct 13, 2021

Change title to User access.
image

@SjoenH
Copy link
Contributor Author

SjoenH commented Oct 14, 2021

If this works in Prod environment today, (without displaying labels since that is waiting on #159 ) then we may get this into testing today.

@martabenthem
Copy link
Contributor

@ntorsen This feature is now deployed to TEST 😄

@ntorsen
Copy link

ntorsen commented Nov 1, 2021

This has been tested in Test env.

Findings: When renaming the process with as many as 300 characters, the name "sticks" to the tile.
However, if you put in a very long word, the name of the process will go out of the tile. See example below:
image

Works good otherwise- only shows three user in tile, able to hover to see all user, can click this section and get pop-up of all users and what roles they have, also able to add more users here. 💯
@SjoenH @martabenthem

@SjoenH
Copy link
Contributor Author

SjoenH commented Nov 1, 2021

Ping 🔔 @martabenthem
I tested the copy-link button, and it is copying the current URL, which worked when we have the share-box in the same page as the process, but need to be adjusted when used other places.
Correct behaviour, copy the link to the process.

So then we have two things to fix:

  • Text-wrap
  • Copy-share-link

@ntorsen
Copy link

ntorsen commented Nov 1, 2021

I'm guessing that the text-wrap will also fix that users are able to put process as favorite ❤️ ? @SjoenH
Because that is not possible now.

@martabenthem
Copy link
Contributor

@ntorsen you mean in case there is a very long word? If that's what you mean then yeah, the heart will be on the card so it will be possible to fave the process.

@ntorsen
Copy link

ntorsen commented Nov 2, 2021

@martabenthem when adding a long word or a long word in a sentence, it was not possible to put the process as favorite. You can see this from the picture I attached above. However, I see that there has been made some changes now :-)
image

@SjoenH
Copy link
Contributor Author

SjoenH commented Nov 2, 2021

  • The heart should probably not be centred with the text, but be aligned top like the other cards.

@SjoenH
Copy link
Contributor Author

SjoenH commented Nov 4, 2021

@ntorsen @Linedueo Ready for testing: https://web-vsm-test.radix.equinor.com

@Linedueo
Copy link

Linedueo commented Nov 4, 2021

@SjoenH ser bra ut!

@ntorsen
Copy link

ntorsen commented Nov 5, 2021

@SjoenH working good 👍

  • Copy-share-link is working
  • Can add users from main page (doesn't have to enter process to add users)
  • Three users is showing, when hovering all users will come up as well as clicking on right down side of the tile
  • Text is within tile (used many characters)
  • Heart when favoriting a process is aligned at the top

@martabenthem
Copy link
Contributor

@askbulle @knudsvik this feature is ready for you to check 👍

@knudsvik
Copy link
Contributor

knudsvik commented Nov 5, 2021

It looks awesome! The only comment I have is that the following two notations should be the same word? Not directly related to this issue, also a problem with the current prod version. But should ideally be fixed, maybe in this PR? I would prefer they both say "modified".

image

@martabenthem
Copy link
Contributor

martabenthem commented Nov 5, 2021

@knudsvik nice catch! I can easily modify it in this PR indeed.

@martabenthem
Copy link
Contributor

@askbulle @knudsvik this feature has now been released.

@SjoenH
Copy link
Contributor Author

SjoenH commented Nov 8, 2021

@martabenthem remember to move the cards when the status updates. 😄

@martabenthem
Copy link
Contributor

@SjoenH apparently if you reopen the issue by mistake the card is moved automatically to pending release. Closing the issue back does not move the card back to released.

@SjoenH
Copy link
Contributor Author

SjoenH commented Nov 8, 2021

Ah! That makes sense 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end Frontend code, functionality, or client-side interactions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants