Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should require workflow to be dictionary, or handle it consistently if not #56

Closed
perolavsvendsen opened this issue Jul 22, 2021 · 0 comments
Assignees

Comments

@perolavsvendsen
Copy link
Member

The workflow parameter can be given as anything, and will be directly inserted into outgoing metadata. However, it shall be an object and there are also snippets in the code that suggests that object (dict) is enforced.

String input is expected:

workflow: Optional[str] = None,

Dictionary is made:

self._meta_fmu["workflow"] = OrderedDict()

...but actual behavior is that if a string is given as an argument, the string is carried through fmu-dataio into the outgoing metadata where it is still a string.

Needs some investigation.

Also, there is a typo here that should be fixed:

self._meta_fmu["workflow"]["refence"] = self._workflow

*reference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant