Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Ammonia (NH3) to the parameters database #610

Closed
EvenSol opened this issue Mar 31, 2023 · 0 comments · Fixed by #611
Closed

add Ammonia (NH3) to the parameters database #610

EvenSol opened this issue Mar 31, 2023 · 0 comments · Fixed by #611
Assignees
@EvenSol
Labels
enhancement New feature or request
Milestone
v.2.4.7

Comments

@EvenSol
Copy link
Collaborator

EvenSol commented Mar 31, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.
Ammonia should be available as a component in the database.

Describe the solution you'd like
Add parameters for ammonia to the COMP.csv file and INTER.csv file.
Add a unit test to check that the model gives correct results.

Additional context
Pure component parameter should be taken from reference databases/book such as properties of liquids and gasses.
https://webbook.nist.gov/cgi/cbook.cgi?ID=C7664417&Mask=4
@EvenSol EvenSol self-assigned this Mar 31, 2023
@EvenSol EvenSol added the enhancement New feature or request label Mar 31, 2023
@EvenSol EvenSol linked a pull request Mar 31, 2023 that will close this issue
610 add ammonia nh3 to the parameters database #611
Merged
@EvenSol EvenSol added this to the v.2.4.7 milestone May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EvenSol EvenSol

Labels
enhancement New feature or request
Projects
None yet
Milestone
v.2.4.7
Development

Successfully merging a pull request may close this issue.

610 add ammonia nh3 to the parameters database equinor/neqsim
1 participant
@EvenSol