Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISO dates are parsed differently on mac vs linux #877

Closed
berland opened this issue Oct 19, 2022 · 0 comments · Fixed by #878
Closed

ISO dates are parsed differently on mac vs linux #877

berland opened this issue Oct 19, 2022 · 0 comments · Fixed by #878
Assignees
@berland
Labels
bug

Comments

@berland
Copy link
Contributor

berland commented Oct 19, 2022 •
edited
Loading

On Mac, the string "17-01-2017" passes as an ISO date, while on Linux it does not. This is likely from a difference in timegm.

Linux marks this as a not valid date by coincidence, since the iso parser in ecl does not require at least exactly four digits for the string:

https://github.com/equinor/ecl/blob/c69f900fcb53b6e99012f661e56198999e65fb62/lib/util/util.cpp#L2656
@berland berland added the bug label Oct 19, 2022
@berland berland changed the title ISO dates are parsed differnently on mac vs linux ISO dates are parsed differenntly on mac vs linux Oct 19, 2022
@berland berland changed the title ISO dates are parsed differenntly on mac vs linux ISO dates are parsed differently on mac vs linux Oct 19, 2022
This was referenced Oct 19, 2022
Merged
Merged
@berland berland self-assigned this Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@berland berland

Labels
bug
Projects
SCOUT
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restrict ISO parsing to be closer to standard berland/ecl
1 participant
@berland