Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the go tests in the cmd/query folder #248

Open
yngve793 opened this issue Feb 5, 2024 · 0 comments
Open

Refactor the go tests in the cmd/query folder #248

yngve793 opened this issue Feb 5, 2024 · 0 comments

Comments

@yngve793
Copy link
Contributor

yngve793 commented Feb 5, 2024

Tests in main_test.go has been expanded to cover new cases as features has been added or changed. Several of the tested features are hosed in endpoint.go or request.go in the api folder. Maybe it would be more natural to move some of these tests to request_tests.go. It could also be considered to create endpoint_test.go if this is structurally beneficial.

It should also be considered if NormalizeConnection can be tested directly and not via an endpoint.

What is the reason for "utils_main_test.go"?
If we deviate from the pattern where "filename_test.go" test functions in "filename.go" it would be beneficial to add a line or two describing the motivation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant