Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: parallel execution when fitting multiple distributions #34

Closed
KrystofS opened this issue Mar 15, 2023 · 3 comments
Closed

Comments

@KrystofS
Copy link
Contributor

As of now distfit does not take advantage of multicore HW. While parallelism in Python is a bit tricky I think that parallel execution when fitting multiple distributions could be fairly easy and very beneficial improvement.

@erdogant
Copy link
Owner

That would be great indeed. If you have an idea or first approach, post it here and we can see whether it really speeds up. I already did some attempts at parallel programming (it is already in the code but with comments) but for some reason, it does not speed up. I must do something wrong.

@KrystofS
Copy link
Contributor Author

I did not read through the codes but I'd assume it's related to this https://stackoverflow.com/questions/4496680/python-threads-all-executing-on-a-single-core.
Anyways I did attempt to come up with a quick and simple solution #35 that should greatly improve perfomance on multicore machines.

@erdogant
Copy link
Owner

I released the new version with your contribution! Thank you!
https://github.com/erdogant/distfit/releases/tag/1.8.0

Update to the latest version with pip install -U distfit
If it breaks somehow, let me know asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants