Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identification fails for files in a batch that aren't v2s #417

Closed
lynnntropy opened this issue May 21, 2017 · 5 comments
Closed

Identification fails for files in a batch that aren't v2s #417

lynnntropy opened this issue May 21, 2017 · 5 comments

Comments

@lynnntropy
Copy link

Problem case:
test

Episodes 1-4 are identified correctly, however, it seems that this causes Taiga to assume every filename must have the "v2" in that position, and fails to recognize the rest of the files as the same show, resulting in this:

progess

I'm sure the existence of v2s isn't the only issue here (there's no way this is the first show I've watched that has them), but they seem to be triggering the problem in this case.

When I play one of the unrecognized episodes, it seems to be trying to look for a show with the title of 'Nichijou <episode number>', like so:

3

@erengy
Copy link
Owner

erengy commented May 22, 2017

Taiga's filename parser Anitomy sees a known pattern in the filenames with v2, which helps with the recognition. Other filenames are ambiguous due to 1080.

You can either add a p after 1080:
[DESS]Nichijou_05_1080p.BD.FLAC.Underwater-Commie_[D7F8E39D].mkv

...or wrap the release information within brackets:
[DESS]Nichijou_05_[1080.BD.FLAC.Underwater-Commie]_[D7F8E39D].mkv

@tophf
Copy link

tophf commented May 22, 2017

I think Taiga could safely assume 1080 stands for 1080p because only a handful of shows have as many episodes and those are viewed live on TV. Especially when two numbers are present in the file name.

@lynnntropy
Copy link
Author

Yeah, after I posted this I realized I wasn't really thinking about it the right way... That's a hell of a hard-to-parse filename if I've ever seen one. Thanks for the explanation.

I do think the suggestion to assume numbers like 1080 and 720 are resolutions is an interesting one. Even if it causes the recognition to fail in the case of shows that actually have that many episodes, it's only going to fail for a couple of episodes out of hundreds, which I could see being a reasonable enough compromise.

@bbtora
Copy link

bbtora commented May 18, 2018

Having the same issue with the same anime files. Do I really have to rename a perfect archive?

@erengy erengy added this to the v2.0 milestone Jan 7, 2024
@erengy
Copy link
Owner

erengy commented Jan 7, 2024

Anitomy's development branch now has a special case for handling 1080. This will be available in v2.

>anitomy "[DESS]Nichijou_05_1080.BD.FLAC.Underwater-Commie_[D7F8E39D].mkv"
┌──────────────────────────────────────┐
│ Element          │ Value             │
│──────────────────────────────────────│
│ release_group    │ DESS              │
│ title            │ Nichijou          │
│ episode          │ 05                │
│ video_resolution │ 1080              │
│ source           │ BD                │
│ audio_term       │ FLAC              │
│ episode_title    │ Underwater Commie │
│ file_checksum    │ D7F8E39D          │
│ file_extension   │ mkv               │
└──────────────────────────────────────┘

@erengy erengy closed this as completed Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants