Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider adding support for phpunit/phpunit:^8 #368

Closed
localheinz opened this issue Nov 18, 2023 · 4 comments
Closed

Consider adding support for phpunit/phpunit:^8 #368

localheinz opened this issue Nov 18, 2023 · 4 comments
Assignees
@localheinz
Labels
enhancement

Comments

@localheinz
Copy link
Member

localheinz commented Nov 18, 2023 •
edited
Loading

Follows #291.
@localheinz localheinz self-assigned this Nov 20, 2023
@mvorisek
Copy link
Contributor

mvorisek commented Nov 22, 2023 •
edited
Loading

also all ^9 and ^10 should be allowed for testing lowest versions like in https://github.com/atk4/ui/blob/5.0.0/.github/workflows/test-unit.yml#L141, slow detector should simply not limit the lowest phpunit minor version

@mvorisek mvorisek mentioned this issue Nov 22, 2023
Closed
@localheinz
Copy link
Member Author

Fixed with #394.

@localheinz
Copy link
Member Author

@mvorisek

I will see what I can do about widening version constraints, but I will not widen version constraints beyond what I can prove works.

@localheinz
Copy link
Member Author

@mvorisek

Released as ergebnis/phpunit-slow-test-detector:2.7.0.

@mvorisek mvorisek mentioned this issue Dec 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@localheinz localheinz

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@localheinz @mvorisek