Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make MONITOR per-session? #1053

Closed
slingamn opened this issue May 26, 2020 · 1 comment
Closed

make MONITOR per-session? #1053

slingamn opened this issue May 26, 2020 · 1 comment
Milestone

Comments

@slingamn
Copy link
Member

Right now, MONITOR operates at the client level, so rules added by one session will result in notifications sent to a different session.

It seems like client code will assume that MONITOR is per-session (e.g., that rules have to be re-added on every reconnection), so it would be better if Oragono implemented it at the session level as well.

@slingamn slingamn added this to the v2.2 milestone May 26, 2020
@DanielOaks
Copy link
Member

Hmm. Yeeeah it probably makes sense to do this. If MONITOR were used by end users then it'd make sense to e.g. persist it across the whole account but since it's mostly just client software transiently trying to check whether users they still have chat windows open for exist, per session makes a lot more sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants