-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding JSON output #3
Comments
My first pass at this produces the following output:
Update: Added I need concrete feedback as to what would be appropriate and useful output |
This actually looks pretty good. I'm not sure of the need for a I do have a feature request, adding a @Flag(default: true, inversion: .prefixedNo)
var pretty: Bool This will turn on prettification by default and passing --no-pretty will turn it off, that seems like the best default to me. |
I'm hesitant to add more exposed features to a utility I want to keep simple. Can you argue against pretty JSON for me? As far as I know, decoders can ignore the pretty printing. I want to introduce only one format (non-pretty or pretty) and a single option (--json / -j) to keep that exposed surface area small. I think there's value to having a version in case the output changes but agree the Update: Pushed version to |
No, you are correct. I don't have a good argument against pretty JSON being the only option. I agree with the |
I just posted my Semantic Versioning code to a gist, it might be useful: https://richardstelling.com/Swift-Gists/#semantic-versioning |
@rjstelling How about a single digit: version 1, 2, 3...? I don't anticipate changing the JSON output but I'd like to have a version there just in case. |
Personally I prefer to have the option of Semantic Versioning, but 1, 2 etc are still valid semantic versions. So, everyone is a winner. |
I'm going to go with that, then, with the understanding that I expect the JSON to not change much (if at all over time). Closing this issue and pushing the version with JSON support. |
Provide a lightweight JSON output to support scripting.
cc @Impedimenta, @taquitos
The text was updated successfully, but these errors were encountered: