Fix multiple instances and no method 'async' bug #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes ericclemmons#28 closes ericclemmons#30 - added stopdone to wait for server to stop - renamed done to startdone - added conditional for `grunt.task.current.async()` - added testsequence which is able to reproduce the bug without my changes to server.js - added `express:defaults` without `express:defaults:stop` at the end of the file to reproduce missing 'async'
|
I can merge this guy, but I still want it to be known that I can run the whole "custom_delay" block in the Gruntfile without any errors. Dunno if it's a race-condition, or what, but I have not been able to reproduce this since the bug was reported. |
ericclemmons
added a commit
that referenced
this pull request
Dec 16, 2013
Fix multiple instances and no method 'async' bug
This was referenced Dec 16, 2013
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #28
closes #30
grunt.task.current.async()changes to server.js
express:defaultswithoutexpress:defaults:stopat the endof the file to reproduce missing 'async'