Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularize #25

Closed
3 tasks done
ericelliott opened this issue Jun 22, 2015 · 7 comments
Closed
3 tasks done

Modularize #25

ericelliott opened this issue Jun 22, 2015 · 7 comments
Milestone

Comments

@ericelliott
Copy link
Collaborator

Please complete #24 first.

Stop using the hacky concat build.

  • Use ES6 modules
  • Drop applitude support (it's obsolete)
  • Use separate client/server build entry points and share common features between them.
.
└── cuid
    ├── build
    │   ├── client
    │   └── server
    ├── source
    │   ├── client
    │   └── server
    └── test
        ├── client
        └── server

Ignore build directory in diffs

You can ignore build files in diffs.

Create a .gitattributes file in the repo root:

build    -diff
@therealklanni
Copy link
Contributor

What approach did you have in mind for the build? Browserify for client?

Additionally, are you wanting to use Babel and go full ES6 on this b***? 🤘

@therealklanni
Copy link
Contributor

OK, I see that the boilerplate mentioned in #24 uses webpack, so I'll assume that.

@therealklanni therealklanni mentioned this issue Jul 3, 2015
@ericelliott
Copy link
Collaborator Author

Yep. Webpack! =)

@therealklanni
Copy link
Contributor

Works pretty well with ES6. I'm not sure the minification is working, though. I'll have to look at the webpack docs on that.

Edit: resolved minification

@therealklanni
Copy link
Contributor

@ericelliott Seems testling is experiencing technical difficulties. What do you want to use for client tests?

@therealklanni
Copy link
Contributor

@ericelliott you originally had slug as a method on cuid, would you be OK with changing that so they can be imported independently (recommended)?

import { cuid, slug } from 'cuid'

@ericelliott
Copy link
Collaborator Author

Seems testling is experiencing technical difficulties. What do you want to use for client tests?

blue-tape (see boilerplate), run client tests on Sauce Labs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants