Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 support #3

Open
vadmium opened this issue Feb 15, 2014 · 1 comment
Open

Python 3 support #3

vadmium opened this issue Feb 15, 2014 · 1 comment

Comments

@vadmium
Copy link

vadmium commented Feb 15, 2014

You might be interested in some small changes I made to a version of this package. They are in the /usenet/pynzb/ directory at https://bitbucket.org/vadmium/pyrescene/src/py3/usenet/pynzb/. Unfortunately I don’t think Bitbucket provides a page with a log or diff of a directory, but here is a summary of my changes:

  • Fix NZBSegment.set_message_id() method call in “expat_nzb.py”
  • Use encoded byte string instead of text in the tests suite
  • Handle “basestring” removal from Python 3 in “base.py”
  • Use BytesIO rather than StringIO in the Element Tree and “lxml” implementations

The result should work on Python 3 and Python 2 with the same code, although it would drop Python < 2.6 support. Let me know if you would like to me to migrate these changes from Mercurial to Git.

@vadmium
Copy link
Author

vadmium commented Jan 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant