Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageOpts.flip does nothing #86

Closed
hombit opened this issue May 20, 2022 · 3 comments
Closed

ImageOpts.flip does nothing #86

hombit opened this issue May 20, 2022 · 3 comments

Comments

@hombit
Copy link

hombit commented May 20, 2022

It looks like flipping is not set up whenJS9Prefs = {"imageOpts": {"flip": "y"}} specified in js9prefs.js or when passed via query parameter ?flip=y. Thus these two links show the same image orientation:
https://js9.si.edu/js9/js9.html?url=https://hea-www.cfa.harvard.edu/~eric/coma.fits.gz
https://js9.si.edu/js9/js9.html?url=https://hea-www.cfa.harvard.edu/~eric/coma.fits.gz?flip=y

@ericmandel
Copy link
Owner

Thanks, that's a bug, which I will track down.

@ericmandel
Copy link
Owner

Duh, flip, rotate, rot90 also have to be treated specially, but this is now fixed and updated in GitHub (btw, use '&' to separate query params, not '?' as in your report above):

Screen Shot 2022-05-20 at 12 44 32 PM

@hombit
Copy link
Author

hombit commented May 20, 2022

Ah, sorry, I misprinted it. Thanks for fixing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants