Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colormap changes #329

Open
zeneofa opened this issue May 7, 2018 · 4 comments
Open

colormap changes #329

zeneofa opened this issue May 7, 2018 · 4 comments

Comments

@zeneofa
Copy link

zeneofa commented May 7, 2018

Hi,

Would it be possible to expose a cmap kwargs for the respective plots? The accent colours on certain devices make it difficult, especially for colour blind individuals, to distinguish the colours. I used the set13 or paired colormaps from palettable.colorbrewer. It would be nice if the user can supply his/her own colour map.

@ericmjl
Copy link
Owner

ericmjl commented May 7, 2018

@zeneofa yes, definitely! Are you willing to put in a PR for this?

@zeneofa
Copy link
Author

zeneofa commented May 7, 2018

sure, I can put something together :), will have to be a bit later though...

@ericmjl
Copy link
Owner

ericmjl commented May 7, 2018

Not a problem. I'm also a bit swamped at the moment, which is why I asked 😄. Looking forward to the PR!

Some things that I can think of that will help with usability include:

  • docstrings
  • error messages for invalid colormaps
  • an example use case that can be executed.

@Rabeez
Copy link
Collaborator

Rabeez commented Jan 16, 2020

Work in progress branch node_cmap.

It is missing

  • Error handling
  • Tests

Anyone willing to take a crack at finishing the implementation is more than welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants