Add supervision tree #1
Labels
enhancement
New feature or request
Comments
Merged
zuiderkwast
added a commit
that referenced
this issue
Feb 22, 2024
This change adds a supervisor for client processes, so a client process can crash without affecting the other client processes or the ered instance. (An ered client may crash e.g. due to a bug in OTP's TLS implementation.) To keep track of missing or dead client processes, the ered process manages monitors to all ered_client processes, so it can properly return errors to commands handled by a crashed client process. `ered:command/3,4` returns a value in all situations, but `ered:command_async/4` is not guaranteed to always return a value. Specifically, if the client process crashes at the same time as the command is issued, the async callback function may never be called. Fixes #1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In general, processes should belong to a supervision tree. At least most of them.
This is considered good OTP style. (Hypothetically, if trap exit is later added to a process started using spawn_link, the process is not killed by the link. If it's instead managed by a supervisor, it is brutally killed even if it's trapping exits. One should not re-invent supervisors.)
The text was updated successfully, but these errors were encountered: