Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Survival going up #16

Closed
remram44 opened this issue Dec 8, 2016 · 6 comments
Closed

Survival going up #16

remram44 opened this issue Dec 8, 2016 · 6 comments

Comments

@remram44
Copy link

remram44 commented Dec 8, 2016

I ran survival_plot.py over ReproZip's 1.0.x branch and got this:

survival_plot

I imagine the graph going back up might be caused by duplication? (there are several packages in the repository which share some code) It's still surprising 😅

@erikbern
Copy link
Owner

erikbern commented Dec 8, 2016

It's because both the numerator and the denominator changes over time. Both of them go to zero. In your case there are only so many commits that reached 2.5 years old versus a lot more commits reached 1 year of age. So if the denominator goes down then the ratio goes up.

Hope this explanation makes sense

@erikbern erikbern closed this as completed Dec 8, 2016
@remram44
Copy link
Author

remram44 commented Dec 8, 2016

No, I can't wrap my head around this 😳

Is the X axis project time or commit age?

@erikbern
Copy link
Owner

erikbern commented Dec 8, 2016

X axis is commit age

@erikbern
Copy link
Owner

erikbern commented Dec 8, 2016

here's a scenario. project has two commits, one from 2000, one from 2015. today is 2016. the first commit is still present in the code base, the second one was reverted in 2016.

first year: 100% because both commits were in the code base
second year: 50% because the second commit was removed
third year: 100% because now only the first commit counts (we don't know anything about the second commit, could be reverted in the future)

@remram44
Copy link
Author

remram44 commented Dec 8, 2016

I see! (commits that age still present)/(commits that age), it makes sense. Thanks for explaining!

@erikbern
Copy link
Owner

erikbern commented Dec 8, 2016

you got it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants