Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom scale #314

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Custom scale #314

wants to merge 2 commits into from

Conversation

eblanca
Copy link

@eblanca eblanca commented Sep 4, 2017

During import, when converting from float to integer values, the caller can now specify a custom floating point value.
Old behavior is kept, and existing application won't break.

I figured out how to use that SFE_BAD_COMMAND_PARAM in case of wrong parameter, maybe that needs fixing...

@erikd
Copy link
Member

erikd commented Sep 4, 2017

This seems sane, but the formatting doesn't match the rest of the file and the documentation (in doc/command.html) needs updating.

@eblanca
Copy link
Author

eblanca commented Sep 5, 2017

Oh right, I will fix both.

BTW, in statement
if (psf->float_int_mult && psf->float_max < 0.0)
what's the purpose of that "psf->float_max < 0.0" test ?
I don't get it, maybe it checks for the very first setting of float_max (I see you init it with -1.0) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants