Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

Merge peep functionality into pip #7

Closed
erikrose opened this issue Jul 23, 2013 · 7 comments
Closed

Merge peep functionality into pip #7

erikrose opened this issue Jul 23, 2013 · 7 comments

Comments

@erikrose
Copy link
Owner

Make pip check against some kind of local hashes.

Put the hashes somewhere proper, not in comments. Either mess with the reqs.txt syntax (and then we'd need a fallback parser in pip—eww) or find some little hole in the grammar to abuse. For example Daniel Holth at one point had the idea of abusing the extras syntax, like requests[ed25519=….]==1.2.0. http://peak.telecommunity.com/DevCenter/setuptools#declaring-extras-optional-features-with-their-own-dependencies

@erikrose
Copy link
Owner Author

"Any of these 5 hashes" is definitely something we need to support, because of different platforms/archs.

@erikrose
Copy link
Owner Author

Also, pip doesn't verify the signatures on wheels. Only wheel verify does. So maybe make a pip mode that does that.

@erikrose erikrose reopened this Jul 23, 2013
@andreif
Copy link

andreif commented Jul 27, 2013

I am not a big fan of reqs.txt format. It would be nice to have some progress here and make a better format (in Python finally!). It would also be nice to use some default name, say Pipfile, so that "peep install" would use it as input. These changes are too much for pip though.

@andreif
Copy link

andreif commented Jul 27, 2013

On the other hand, a Python file should have .py extension, so maybe something like requirements.py, packages.py, peeps.py :) would make more sense...

@erikrose
Copy link
Owner Author

erikrose commented Sep 6, 2013

See pypa/pip#1175 (comment) for some design work toward the merge.

@erikrose
Copy link
Owner Author

erikrose commented Apr 7, 2014

We're going to sprint on this at PyCon next week.

@edmorley
Copy link
Contributor

This was completed in pypa/pip#3137 and the feature now exists in pip 8:
https://pip.pypa.io/en/stable/user_guide/#hash-checking-mode
https://pip.pypa.io/en/stable/reference/pip_install/#hash-checking-mode

Peep is now deprecated for modern versions of pip - migration help can be found in the README:
https://github.com/erikrose/peep/blob/master/README.rst

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants