forked from symfony/symfony
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feature symfony#19495 [master][console] Allow multiple options to be …
…set. (SpacePossum) This PR was merged into the 3.2-dev branch. Discussion ---------- [master][console] Allow multiple options to be set. | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | License | MIT This PR add the possibility to set multiple options on a formatted string output. Example: ```php $output->writeln('<fg=green;options=bold,underscore>Test</>'); ``` Secondly it makes the behavior on invalid values consistent. ```php // current $output->writeln('<fg=lime;>Test</>'); // throws exception $output->writeln('<options=italic;>Test</>'); // silent ignore // new $output->writeln('<fg=lime;>Test</>'); // throws exception $output->writeln('<options=italic;>Test</>'); // throws exception ``` All other changes are about making the code more strict or other SCA/CS fixes. Commits ------- 1430138 Allow multiple options to be set.
- Loading branch information
Showing
2 changed files
with
82 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters