Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe they are not bugs. #24

Closed
GoogleCodeExporter opened this issue Mar 14, 2015 · 3 comments
Closed

Maybe they are not bugs. #24

GoogleCodeExporter opened this issue Mar 14, 2015 · 3 comments

Comments

@GoogleCodeExporter
Copy link

When porting box2d to actionscript, I found some problems, but because I 
didn't study the code deeply, so maybe they are designedly.

1. Possible a contact is passed to contactListerner.BeginContact, but 
never passed to contactListerner.EndContact, even if it has been destroyed:
a. one case: the contact is a touched in last step, but in current step, 
even the aabbs are not overlapped, then the contact is destroyed, so the 
EndContact is not called for this contact.
b. other reasons make the contact destroyed:
  - some Destroy (contact)s in contactManager.Collide
  - destroy fixtures

2. SyaGoodbye is not called in body.DestroyFixture and body.DestroyJoint. 
Maybe this is deliberately.

3. Should "BufferMove (fixture)" also be called when a body become dynamic 
from static? Image a situation: in a non-gravity enviroment, two static 
shapes are ovelapped, then make one dynamic. Seems now no contacts will be 
created between them.

4. Should ContactListener.PreSolve () only be called when (contact.m_flags 
& e_touchingFlag) != 0 && newCount > 0 

5. If I change the ShouldCollide rules runtimely, how can I make the core 
api knows this change and call FlagForFiltering?

6. Can I change joint.m_collideConnected runtimely, if true, how can I 
make the core api knows this change and call FlagForFiltering?

7. About the body mass, if there is only one shape with zero density in a 
body, then the body is static, but if another shape with non-zero density 
is added to the body, the body will become dynamic. If it is the design, 
no problems here. I just thnk it is more reasonable to make the body 
static only if there is a zero denstiy shape in the body.

That is all, maybe I'm wrong on these points.

btw, I like the new broadphase very much!


Original issue reported on code.google.com by Tapir....@gmail.com on 29 Sep 2009 at 11:23

@GoogleCodeExporter
Copy link
Author

sorry, my english is not good. int the last point, it should be "I just thnk it 
is 
more reasonable to make the body static as long as there is a zero denstiy 
shape in 
the body."

Original comment by Tapir....@gmail.com on 29 Sep 2009 at 11:39

@GoogleCodeExporter
Copy link
Author

sorry, I'm absolutely wrong on the first point. :D

Original comment by Tapir....@gmail.com on 29 Sep 2009 at 11:53

@GoogleCodeExporter
Copy link
Author

This post is more of a discussion than a bug report or feature request. Please 
post 
this on the forums. If we resolve that something needs to be changed, please 
file and 
issue again, but only one issue per issue please.

Original comment by erinca...@gmail.com on 20 Nov 2009 at 6:50

  • Changed state: Invalid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant