npm run scripts and dependencies for building OSX dist #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also added support for rebuilding image assets from icon.svg
|
urrgh . stupid. I rebased my local and pushed it back to github hence extra commits :-( |
|
redo |
|
Thanks. I will look at this next week. electron-packager was already on my radar. When you say the app is smaller, do you know what's omitted? |
|
it symlinks a few things instead of multiple copies, eg. Looking now I'm wondering if the fact that they weren't symlinked in your download might have been a result of the filecopy in makedist.py because they are definitely symlinked in electron-prebuilt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
includes support for building .icns file from SVG as required for OSX build for correct icon
I also added support for rebuilding icon-128.png from the SVG as well because it was there. :-)
The resulting .app is about a 3rd the size of the current download