Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stdlib: remove unnecessary undefined from records #6666

Merged
merged 1 commit into from
Jan 17, 2023
Merged

stdlib: remove unnecessary undefined from records #6666

merged 1 commit into from
Jan 17, 2023

Conversation

kikofernandez
Copy link
Contributor

Removes unnecessary undefined types added to the supervisor state record.

@kikofernandez kikofernandez added team:PS Assigned to OTP team PS documentation bug Issue is reported as a bug labels Jan 13, 2023
@kikofernandez kikofernandez self-assigned this Jan 13, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 13, 2023 •
edited
Loading

CT Test Results

No tests were run for this PR. This is either because the build failed, or the PR is based on a branch without GH actions tests configured.

Results for commit e9a07ae

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@kikofernandez kikofernandez added the testing currently being tested, tag is used by OTP internal CI label Jan 13, 2023
rickard-green
rickard-green requested changes Jan 16, 2023
View reviewed changes
lib/stdlib/src/escript.erl Outdated Show resolved Hide resolved
lib/stdlib/src/supervisor.erl Outdated Show resolved Hide resolved
@kikofernandez kikofernandez force-pushed the kiko/stdlib/fix-record-types/OTP-18393 branch from d1ae282 to e9a07ae Compare January 16, 2023 12:54
@kikofernandez
Copy link
Contributor Author

Thanks for the feedback @rickard-green !
I have taken your suggestion and put everything into a single commit, given that it is such as small change

@kikofernandez kikofernandez requested review from rickard-green and removed request for IngelaAndin January 16, 2023 12:56
@kikofernandez kikofernandez merged commit 6adaf39 into erlang:maint Jan 17, 2023
@kikofernandez kikofernandez deleted the kiko/stdlib/fix-record-types/OTP-18393 branch January 17, 2023 07:55
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickard-green rickard-green rickard-green approved these changes

Assignees

@kikofernandez kikofernandez

Labels
bug Issue is reported as a bug documentation team:PS Assigned to OTP team PS testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kikofernandez @rickard-green