Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New dialyzer output format breaks editors auto-search #880

Closed
jlouis opened this issue Oct 18, 2015 · 2 comments
Closed

New dialyzer output format breaks editors auto-search #880

jlouis opened this issue Oct 18, 2015 · 2 comments
Labels
enhancement new behaviour or additional functionality

Comments

@jlouis
Copy link

jlouis commented Oct 18, 2015

FYI, the new format for dialyzer output:

_build/default/lib/dht/src/dht_refresh.erl
  16: Invalid type specification for function dht_refresh:range/1. The success typing is ({_,_,_}) -> 'ok'
  21: The pattern {'nodes', _, _Token, Nodes} can never match the type {'error',_}
  22: The created fun has no local return
  31: Call to missing or unexported function dht_net:ping/2

Thwarts editor support in many editors. Most editors understand the notion of _build/default/lib/dht/src/dht_refresh.erl:16 and can scan+jump to such errors automatically. The new format has no such direct support and every editor now has to employ helpers for the rebar3 output to achieve the same. This is unnecessary work, so this issue exist to make sure there is an option to disable the new output and get the old output format which has editor-search-support.

@Licenser
Copy link
Contributor

Perhaps TERM=dumb should fully revert to the 'old' format?
Other then that the _build/default/18.1.dialyzer_warnings will contain the old warnings so a simple (but ugly?) alternative would be rebar3 dialyzer; cat _build/default/18.1.dialyzer_warnings

@ferd ferd added the enhancement new behaviour or additional functionality label Nov 14, 2015
@tsloughter
Copy link
Collaborator

I think we should be able to turn all things like this off.

ferd added a commit to ferd/rebar3 that referenced this issue Jan 21, 2017
Fixes issue erlang#880

May break backwards compat with projects that manually called the
dialyzer formatter, but we never documented or expected this to be
exposed.
@ferd ferd closed this as completed Jan 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new behaviour or additional functionality
Projects
None yet
Development

No branches or pull requests

4 participants