remove large comment blocks from templates and use maps in sup #2069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the map format started being used only ~OTP-18. I guess we're okay with starting the drop there? By OTP-22 that's the one we should be supporting anyway. |
|
Oh, I thought it was in 17. But yea, I guess even if it 18 it isn't an issue. |
|
Yeah I think I'll be fine with this. Question is if we want to merge it now, or wait until 22 is closer. I guess it's not a super hard deprecation yet, it will just mess up with folks on 17.x calling |
|
Yea, I think it can safely go in now. And merging only put its in master/nightly, not a new release yet. So we'll be closer and closer to 22 by the time we release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hate those big comment blocks :)
Also updated the supervisor init comment and body.