Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure provider hook calls don't crash because of invalid command line arguments #2154

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tolbrino
Copy link
Contributor

Normally the CLI arguments are intended for the provider which is called
directly. When these are forwarded to other providers through hooks
things might break.

@ferd
Copy link
Collaborator

ferd commented Sep 1, 2019

This is a good fix, but we'll need to add a test for this before we merge it. This is core dispatching functionality we shouldn't change without repeatable validation.

@ferd ferd added the tests missing awaiting the adition of tests to the pull request label Jan 25, 2020
@tsloughter
Copy link
Collaborator

ping @tolbrino

@tolbrino
Copy link
Contributor Author

ping @tolbrino

I got blocked by trying to get a test working, but to no avail. I will take a look again some time later this week.

…e arguments

Normally the CLI arguments are intended for the provider which is called
directly. When these are forwarded to other providers through hooks
things might break.
@tolbrino tolbrino force-pushed the tb-fix-prodiver-hook-args2 branch from 99477cf to 1d8db94 Compare June 3, 2020 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests missing awaiting the adition of tests to the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants