Support CRLF in shell ENV files #2793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferd
force-pushed
the
support-crlf-in-shell-env-files
branch
from
2e40d50
to
06438a4
Compare
As reported in a comment in erlang#2090 the current mechanism only breaks on a \n and does not even respect the \r\n grapheme cluster. So instead of using string functions, we go to regular expressions where we can specify both endings without a problem.
ferd
force-pushed
the
support-crlf-in-shell-env-files
branch
from
06438a4
to
53bba4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in a comment in #2090 the current mechanism only breaks on a \n and does not even respect the \r\n grapheme cluster. So instead of using string functions, we go to regular expressions where we can specify both endings without a problem.