add support for reading in environment variables from a file #2090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsloughter
force-pushed
the
env-file
branch
5 times, most recently
from
ae1437f
to
7fabba2
Compare
|
I think this is ready now. I based the rules on what works when doing |
tsloughter
force-pushed
the
env-file
branch
2 times, most recently
from
c59bb94
to
b95712b
Compare
ferd
reviewed
May 26, 2019
ferd
reviewed
May 27, 2019
Co-Authored-By: Fred Hebert <mononcqc@ferd.ca>
|
This does not work properly if the newline is \r\n instead of just \n, it leaves the \r at the end of the env variable. |
ferd
added a commit
to ferd/rebar3
that referenced
this pull request
May 23, 2023
As reported in a comment in erlang#2090 the current mechanism only breaks on a \n and does not even respect the \r\n grapheme cluster. So instead of using string functions, we go to regular expressions where we can specify both endings without a problem.
ferd
added a commit
to ferd/rebar3
that referenced
this pull request
May 23, 2023
As reported in a comment in erlang#2090 the current mechanism only breaks on a \n and does not even respect the \r\n grapheme cluster. So instead of using string functions, we go to regular expressions where we can specify both endings without a problem.
See if #2793 works for you? |
ferd
added a commit
to ferd/rebar3
that referenced
this pull request
May 23, 2023
As reported in a comment in erlang#2090 the current mechanism only breaks on a \n and does not even respect the \r\n grapheme cluster. So instead of using string functions, we go to regular expressions where we can specify both endings without a problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2085