This repository has been archived by the owner on Sep 22, 2024. It is now read-only.
[WIP] Integrate with new UI #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I may have been doing something wrong because |
|
I reduced the file size down to 1.7MB by not including the heavy .js.map file, fixed in 55a6a3d |
|
Sourcemaps are good if you're opening browser DevTools with production site, and they are not downloaded until then. But yeah, we don't need then as part of the bundle. |
|
If you need the .map files for debugging purposes, please see section about running development release, which serves all files from the yarn build, when a browser tries to download them. |
|
Awesome! |
michalslaski
approved these changes
Mar 12, 2017
There was a problem hiding this comment.
I'm happy with this PR and will merge. Thanks!
BTW, please check if fallback to index.html works as expected (see 2c9a53e).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #10
Introduces new UI. I've updated only
Makefileto build new UI and move output toapps/epl/priv/htdocs. This waybootsatrapscript can include it in bundle and application can serve static files. Only thing I have problem setting up is fallback to/index.htmlwhen route not found. This should be handled by frontend and server should redirect everything to/index.html/ cc @michalslaski @arkgil