ETS details view #82
Merged
ETS details view #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make mechanism which allows for passing and storing additional information for ETS tracing works properly.
- Add necessary functions to the epl_ets_metric module in order
to transform and process ETS traffic counters
- Extend the epl_ets_viz_map module by the functions which allows
for creating the ETS traffic setction in the Vizceral map
- Modify the epl_ets module to make it possible to send ETS
traffic data to the web UI
- Improve code style
Display an ETS table identifier. Make it display by default instead of table name.
- modify way of enabling/disabling ETS tracing through
a websocket
- improve Vizceral map's ETS traffic section to properly display
ETS traffic graph
- make ETS traffic graph display when click on a particular row
in ETS table view
- enable/disable ETS table tracing using a reference as a table
identifier
- modify binarify/1 and namify/1 functions from the epl_viz_map
module in order to handle a reference as a table indentifier
- modify the epl-ets UI plugin to handle above changes
baransu
reviewed
Aug 14, 2017
| @@ -22,7 +22,11 @@ class ETS extends Component { | |||
| graph: boolean, | |||
| showTab: boolean, | |||
| clickedNode: any, | |||
| vizStyle: object | |||
| view: any, | |||
| @@ -22,7 +22,11 @@ class ETS extends Component { | |||
| graph: boolean, | |||
| showTab: boolean, | |||
| clickedNode: any, | |||
| vizStyle: object | |||
| view: any, | |||
| tabTraceId: any, | |||
| tabTraceId: any, | ||
| definitions: object, | ||
| vizStyle: object, | ||
| loader: object |
| @@ -121,6 +227,9 @@ class ETS extends Component { | |||
| tabs: this.props.data.etsNodeTabs, | |||
| node: this.state.clickedNode | |||
| }} | |||
| tableClicked={tabIds => { | |||
There was a problem hiding this comment.
You can just pass function you're calling at the end:
tableClicked={this.handleTabClick}
| @@ -111,9 +115,12 @@ class TableView extends React.Component { | |||
| ...callStatsInsert, | |||
| ...callStatsLookup | |||
| }; | |||
| return { ...a, ...info, ...callStatsObj }; | |||
| return { | |||
| ...{ tab_id: tab_id, tab_trace_id: tab_trace_id }, | |||
There was a problem hiding this comment.
You can just use create object shorthand.
return {
tab_id,
tab_trace_id,
...info,
...callStatsObj
}| } | ||
|
|
||
| handleTabClick = ({ tabId, tabTraceId }) => { | ||
| this.setState({ |
There was a problem hiding this comment.
React setState is not guaranteed to be sync and can be sometimes scheduled in different ways. It doesn't happen often right now but with new versions of React it will be more common.
In general every time you're updating state based on previous state use setState function syntax instead of this.state syntax because this syntax is binding value and state can be applied later. With function syntax you're always guaranteed to have recent state.
this.setState(state => ({
view: [state.clickedNode, tabId],
tabTraceId: tabTraceId
}));
|
Please add to |
mentels
approved these changes
Aug 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces new
ETS details view.