Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default release is not detected properly #93

Closed
josevalim opened this issue Nov 18, 2013 · 0 comments
Closed

Default release is not detected properly #93

josevalim opened this issue Nov 18, 2013 · 0 comments

Comments

@josevalim
Copy link
Contributor

Currently in the source code, there is a logic to detect the default release when none is specified. However, it does not work as expected. I have attempted a fix but as the code comments are also outdated, I have decided to open an issue.

The current code does sort the releases but sorts them in ascending order:

https://github.com/erlware/relx/blob/master/src/rlx_prv_release.erl#L131

The code comment says they are supposed to be sorted in descending order though:

https://github.com/erlware/relx/blob/master/src/rlx_prv_release.erl#L114

Besides, this code comment says we should abort when the release names are different:

https://github.com/erlware/relx/blob/master/src/rlx_prv_release.erl#L133-L136

But the code behaves differently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant