Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[performance] Moving to recycle bin is slow #23

Open
yfdyh000 opened this issue Apr 27, 2018 · 2 comments
Open

[performance] Moving to recycle bin is slow #23

yfdyh000 opened this issue Apr 27, 2018 · 2 comments

Comments

@yfdyh000
Copy link
Contributor

This is my feeling, it seems to be significantly slower than ordinary moving files in Windows Explorer, about 15 files/s on 7200rpm HDD. Maybe it has performance bottlenecks and can be optimized through multithreading, big buffers, etc?

@1n5aN1aC
Copy link

I am also unsure the source of this, but I recently ran the "automatically choose the recommended action" option with a few thousand duplicates selected, and it took 4+ hours to delete them all, while the initial search was amazingly fast!

Then after I went through a few more manual duplicate selections, it got to deleting them from the undo queue, and took another couple hours to delete them from there.

Still an amazing tool, but very slow if you select and run many at the same time.

@ermig1979
Copy link
Owner

The main reason of this behaviour (slow deleting) is undo/redo feature. The program does not delete images to recycle bin but renames and marks images as hidden. The real deletion is performed if (undo/redo) queue is overflow, or at the end of program, or before the start of new search. For real deletion original names of images are restored and then their are deleted to recycle bin.

If you set 0 to options "Options - Advanced - Queue size of undo" then images will be deleted directly to recycle bin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants