-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test model eos4q1a in CLI and Colab #7
Comments
While fetching the model in CLI, I got the following error. It might be a conda installation |
Hi @Femme-js , I think its a problem of space on your disk, see the following error in your log: Can you try on google colab see if it works there? |
@GemmaTuron the database occupies 688MB of space. |
@Femme-js maybe you just have a lot of tmp files that need to be flushed? You could either delete them yourself or reboot your system? |
Hi @GemmaTuron Testing the model on the CLI and Colab.
On reviewing the error, I noticed there was a typo in the run_generate.sh of the colab notebook
|
Hi @pauline-banye Please instead of screenshots can you provide the log files? You can collect them or at least print the output of running the cells and paste it in a .txt file for example. Thanks! |
Hi @GemmaTuron, I provided the log files and the link to colab as well. I just included the screenshots but I've taken them out now. I'm sorry for the confusion. Regarding the error, I can see /usreos4q1a/bin/python in the generated report on colab. I believe that usreos4q1a is the source of the error. |
Hi @pauline-banye. This path |
Hi @carcablop I guessed there needed to be a / in-between. Oh the link to the colab is referenced in my comment about testing the issue on colab but let me paste it again 👇. |
Thanks @pauline-banye I see the link to colab now, apoloies I went throught he issue veyr fats the other day.
|
Hi @GemmaTuron @pauline-banye and @carcablop I have updated the repo with a colab template in this branch, it was long due https://github.com/ersilia-os/eos4q1a/tree/6-bonus-add-colab-notebook-template-to-the-repo (PR: #9 pending review from @GemmaTuron) I haven't specifically gone through @pauline-banye's notebook yet to figure out where the issue is coming from but I can confirm that the model worked on colab for me and if you run the notebook provided in this branch hopefully it should run for you too. |
Hi @DhanshreeA , Thanks for the work! Is there any reason you created a specific notebook for this repo? Maybe I should have explained it better before, sorry, I missed your bonus issue: all models should work with the template provided in ersilia/notebooks/ersilia-on-colab.ipynb to avoid too many notebook versions, instead of each repo having its own colab version. Otherwise it will become too much to maintain. What do you think? |
Is something different between @DhanshreeA's notebook and the one @pauline-banye was using? |
We have done some changes and this is solved now, can you confirm? Thanks! |
Sure @GemmaTuron , I'm repeating the tests now |
@GemmaTuron The model fetched, served and generated successfully with the updated colab notebook. https://colab.research.google.com/drive/19-8OPvv2LZNkilCKja9JIQK5GIui9tKt#scrollTo=1cg9EqzVnJSs |
Hi @GemmaTuron ! I tested the model on my CLI. It fails to fetch. I am attaching the log here. |
Hi @Femme-js Please have a look at the log file and identify the error to understand how to solve it. Have you considered everything we discussed in this same issue before? |
@GemmaTuron I understand and the maintainability issue makes complete sense! When I was testing this model in colab, it came as a suggestion from Miquel to store this as an artifact within the repo, probably for easy usage but moving on this does not seem like a good idea. Thanks for merging the PR anyway but I realize this has just opened up more technical debt. 😅 |
@GemmaTuron the fragment database that the model needs takes up about 680 MB. |
@Femme-js Could you run |
Yes, I see this was a memory issue. I ran the test again and was able to fetch the model successfully. |
Perfect, let's mark this as completed then! |
Test the model using a single smiles and a .csv file with a few of them to check that it works.
The text was updated successfully, but these errors were encountered: