Skip to content
This repository has been archived by the owner on Aug 3, 2024. It is now read-only.

Groovy support #25

Closed
roadrunner2 opened this issue Sep 7, 2010 · 6 comments
Closed

Groovy support #25

roadrunner2 opened this issue Sep 7, 2010 · 6 comments
Labels

Comments

@roadrunner2
Copy link

It would be great if eclim supported groovy (and possibly grails). My main reason
for looking at eclim was for improved code completion, search, and validation for
groovy code.

@ervandew
Copy link
Owner

Groovy support is on my todo list, but it'll probably be a while
before I can get to it.

@dansomething
Copy link

+1
I would love this as well.

@yveszoundi
Copy link
Contributor

+1, I had a very quick stab at it with basic code completion + source update: https://github.com/yveszoundi/eclim/commit/d08f4422029838f19fff793ec61dbc937f03ed5b

My attempt is just few hours of try-outs, if someone can take it from here that would be great :-)
I'm hoping that the above can be improved to provide decent Groovy support in Eclim.

My current workflow with Groovy or Grails projects (emacs-eclim):

  1. I use Emacs Projectile to look up files and types
  2. I use Ag(the_silver_searcher) to grep/find text via Emacs Ag
  3. I use another Emacs extension that I wrote to run arbitrary Grails commands against a project.
  4. As completion with Eclim is not fast in my attempt, I do not use it often.

Some notes about my eclim fork:

  1. Only completion and source update are supported.
  2. Code completion is not fast, I gave it a try with emacs-eclim.
  3. The manifest could use some improvements to ensure that the groovy JDT classes are resolved properly without Bundle-Classpath references to an explicit jar: https://github.com/yveszoundi/eclim/commit/d08f4422029838f19fff793ec61dbc937f03ed5b#diff-80d5ebeeeedad14f583d9c430968721dR12. After the build I have to copy manually the eclipse Groovy JDT jar from plugins to the eclim groovy folder. Loosing minimum versions could help with upgrades/compatibility in the manifest.

@ervandew
Copy link
Owner

ervandew commented Mar 4, 2014

First off congrats on being the first person to submit support for a new language! I'm very happy to see this. I haven't had time to look at the code in depth or to test it, but the logic looks reasonable at a glance. The only comment I have at the moment is that the code doesn't follow eclim's coding format. Not a huge deal, but it's that much more work on my part to update the code to conform.

When I get a chance (it could be a little while unfortunately), I'll test out your code and hopefully merge it in.

@yveszoundi
Copy link
Contributor

Thanks @ervandew, it wasn't painful with all the great work that you've done. I did notice the code formatting issue as well as the missing vim support(I have mainly used only bare vim over the years..).

I'll send a proper pull request soon, please wait!

  • Compliance to the current code formatting profile.
  • Improvements for the build and code.
  • Workaround classloader issues and manual taks, for now I'll use groovy-eclipse-compiler library.
  • Basic vim support, shouldn't be that hard after looking at how it's currently done.

@yveszoundi
Copy link
Contributor

Hello again,

I made some updates, please see the relevant PR
#312

Thanks,
Yves

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants