Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ratelimiting support #22

Closed
kotx opened this issue Oct 11, 2020 · 3 comments · Fixed by #52
Closed

Ratelimiting support #22

kotx opened this issue Oct 11, 2020 · 3 comments · Fixed by #52
Labels
enhancement New feature or request

Comments

@kotx
Copy link

kotx commented Oct 11, 2020 •
edited
Loading

It would be appreciated to have an interval between requests as a optional parameter. It would be good to support custom ratelimits for self-hosted APIs as well.
As of now the ratelimits for the main instance jikan.moe are:

Daily Limit: Unlimited
30 requests / minute
2 requests / second

Bulk requests must be 1 request / 4 seconds.
@Ervie
Copy link
Owner

Ervie commented Oct 11, 2020

Not a bad idea, I will give it a thought and check if it's worth it when I have a little more free time. I'll keep it issue open for now.

@Ervie Ervie added the enhancement New feature or request label Oct 11, 2020
@vynxc
Copy link
Contributor

vynxc commented Jan 9, 2023

@Ervie i would also love to have this

@aetherstrata aetherstrata mentioned this issue Mar 22, 2023
Merged
@Ervie Ervie closed this as completed in #52 Apr 3, 2023
@Ervie
Copy link
Owner

Ervie commented Apr 4, 2023

This was added as a part of 2.6.0 thanks to @aetherstrata
Will add a page on wiki about this later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add rate limiting support aetherstrata/jikan.net
3 participants
@Ervie @kotx @vynxc