Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the current way to use titles is marked as deprecated #40

Closed
Fribb opened this issue Aug 19, 2022 · 2 comments
Closed

the current way to use titles is marked as deprecated #40

Fribb opened this issue Aug 19, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@Fribb
Copy link

Fribb commented Aug 19, 2022

With the current APIv4 you have the JSON elements for the titles separately available.

  • title
  • title_english
  • title_japanese
  • title_synonyms

Those are marked as Deprecated according to the documentation here

The new way combines all of the titles under a single element titles, example:

"titles": [
      {
        "type": "Default",
        "title": "One Piece"
      },
      {
        "type": "Synonym",
        "title": "OP"
      },
      {
        "type": "Japanese",
        "title": "ONE PIECE"
      },
      {
        "type": "English",
        "title": "One Piece"
      }
    ],
@Ervie Ervie added the enhancement New feature or request label Aug 19, 2022
@Ervie
Copy link
Owner

Ervie commented Aug 19, 2022

That's true. I've started implementing the change (there's more of them), but I'm leaving for vacation tomorrow. When I'll be back, I'm going to do rest of them, including this one.

@Ervie Ervie self-assigned this Aug 19, 2022
@Ervie
Copy link
Owner

Ervie commented Oct 23, 2022

Titles property for Manga and Anime were just added in version 2.3.0 (should be available today). The old properties has been marked as obsolete and removed in version 2.4.0 (whenever it will be released).

@Ervie Ervie closed this as completed Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants