Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetSeasonAsync doesn't have page param #43

Closed
JaoHundred opened this issue Nov 3, 2022 · 7 comments
Closed

GetSeasonAsync doesn't have page param #43

JaoHundred opened this issue Nov 3, 2022 · 7 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@JaoHundred
Copy link

I noticed the GetSeasonAsync method doesn't have overload with page param, in Jikan rest api it has a query param to page.

@Ervie
Copy link
Owner

Ervie commented Nov 4, 2022

Thanks, will check tomorrow

@Ervie Ervie added enhancement New feature or request good first issue Good for newcomers labels Nov 4, 2022
@Ervie
Copy link
Owner

Ervie commented Nov 14, 2022

Added method with paging in version 2.4.1.

@JaoHundred
Copy link
Author

JaoHundred commented Nov 15, 2022

Just checked, now I can pass pages. I saw some weird thing where the consecutive pages get Anime dupes, checked the jikan API and tried to reproduce this, the consecutive pages returned as expected(no anime dupes). Should I open a new issue for this?

I used this cenario:

  • 2020 summer
  • Observed the page 1 results, 2 and so on(2020 summer has only 2 pages)

@Ervie
Copy link
Owner

Ervie commented Nov 15, 2022

Hmm, weird. Can you try to reproduce it? I wrote a short code snippet to test that:
image

The results are different, with no dupes:
image

They are equivalents of https://api.jikan.moe/v4/seasons/2020/summer and https://api.jikan.moe/v4/seasons/2020/summer?page=2 respectively

@JaoHundred
Copy link
Author

Sure, I will take a look at this.

@JaoHundred
Copy link
Author

I feel dumb now, the error was on my end, I was calling twice the first response to fetch the data, sorry for wasting your time with this silliness and thanks for the support.

@Ervie
Copy link
Owner

Ervie commented Nov 15, 2022

No worries, happens to everyone. Just a part of programmer's life :)

@Ervie Ervie closed this as completed Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants