Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: settings sidebar glitch #4635

Merged
merged 1 commit into from
Sep 21, 2023
Merged

fix: settings sidebar glitch #4635

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 0 additions & 4 deletions packages/plugin-forms-ui/src/containers/Properties.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,6 @@ const PropertiesContainer = (props: FinalProps) => {
fieldsGetTypes
} = props;

if (fieldsGroupsQuery.loading) {
return <Spinner objective={true} />;
}

if (fieldsGetTypes.loading) {
return <Spinner />;
}
Expand Down
4 changes: 0 additions & 4 deletions packages/plugin-products-ui/src/containers/product/ProductList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,6 @@ class ProductListContainer extends React.Component<FinalProps> {
history
} = this.props;

if (productsQuery.loading) {
return false;
}

const products = productsQuery.products || [];

// remove action
Expand Down
4 changes: 0 additions & 4 deletions packages/plugin-tags-ui/src/containers/List.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,6 @@ const ListContainer = (props: FinalProps) => {
);
}

if (tagsQuery.loading) {
return <Spinner />;
}

const remove = tag => {
confirm(
`This action will untag all ${type}(s) with this tag and remove the tag. Are you sure?`
Expand Down