fix socialpay deeplink #4972
fix socialpay deeplink #4972
Conversation
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Type: Enhancement
PR Summary: This pull request introduces changes across several files with the primary goal of fixing the deeplink functionality for Social Pay within the plugin-payment-api package. It modifies constants to include trailing commas for better diff readability, updates the Social Pay API to change the source of the deeplink, and adjusts the client-side JavaScript to handle the deeplink navigation specifically for Social Pay. Additionally, it includes minor formatting improvements across various payment methods.
Decision: Comment
📝 Type: 'Enhancement' - not supported yet.
- Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
✅ Small diff: the diff is small enough to approve with confidence.
No details provided.
General suggestions:
- Ensure that the change in the source of the deeplink for Social Pay from
body.response.deeplinktobody.response.descdoes not inadvertently introduce issues with deeplink functionality. It's crucial that thedescfield is validated to contain a proper URL format suitable for deeplink purposes. - Revisit the client-side navigation logic introduced for Social Pay in
script.js. The current implementation might cause redundant navigation actions or unexpected behavior due to the simultaneous use ofwindow.location.hrefandwindow.open. A more streamlined approach to handling deeplinks could enhance user experience and prevent potential navigation issues. - The PR description could be improved by providing more context about the changes made and their impact on the application. Including specific reasons for the changes and how they address the issue at hand can help reviewers understand the intent behind the PR better.
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
| @@ -203,6 +203,10 @@ async function onPaymentClick(payment, invoiceData, prefix) { | |||
|
|
|||
| window.location.href = apiResponse.deeplink; | |||
| window.open(apiResponse.deeplink, 'blank'); | |||
|
|
|||
| if (paymentObj.kind === 'socialpay') { | |||
| window.location.href = apiResponse.deeplink; | |||
There was a problem hiding this comment.
issue (llm): The addition of a conditional redirect specifically for socialpay after already setting window.location.href and opening a new tab with window.open could lead to unexpected behavior or user experience issues. Consider consolidating the navigation logic to ensure a consistent and predictable outcome.
| @@ -116,7 +116,7 @@ export class SocialPayAPI extends BaseAPI { | |||
|
|
|||
| const qrData = await QRCode.toDataURL(body.response.desc); | |||
|
|
|||
| return { qrData, deeplink: body.response.deeplink }; | |||
| return { qrData, deeplink: body.response.desc }; | |||
There was a problem hiding this comment.
issue (llm): Returning body.response.desc as the deeplink instead of body.response.deeplink appears to be a significant change. If this is intentional, ensure that the desc field is correctly formatted and can serve as a deeplink. This change could potentially break functionality if desc does not contain a URL or is not intended to be used as a deeplink.
ISSUE
Context
Your context here. Additionally, any screenshots. Delete this line.
// Delete the below section once completed
PR Checklist