Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix(emailTemplates): checking currentUser #4986

Merged
merged 2 commits into from
Feb 21, 2024
Merged

hotfix(emailTemplates): checking currentUser #4986

merged 2 commits into from
Feb 21, 2024

Conversation

enkhtuvshinD
Copy link
Collaborator

No description provided.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Type: Refactoring

PR Summary: This pull request encompasses a series of refactoring changes across two components within the email templates and calls UI plugins. The modifications include syntax enhancements for function declarations, improved readability through the use of optional chaining, and the addition of trailing commas where missing. Additionally, it simplifies conditional rendering logic for displaying user details and standardizes the formatting of GraphQL queries and mutations.

Decision: Comment

📝 Type: 'Refactoring' - not supported yet.
  • Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
✅ Small diff: the diff is small enough to approve with confidence.
No details provided.

General suggestions:

  • Ensure that the refactoring does not introduce any side effects, especially in the areas where optional chaining and logical OR operations have been introduced for default values.
  • Consider running a thorough UI and integration test to verify that the changes do not affect the existing functionality, particularly in the display of user details and the handling of call integrations.
  • Review the consistency of code style and formatting across the entire codebase to prevent similar piecemeal refactoring in the future. A linter or formatter configuration could help maintain consistency.

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Copy link

sonarcloud bot commented Feb 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@enkhtuvshinD enkhtuvshinD merged commit c7fb920 into dev Feb 21, 2024
4 of 5 checks passed
@enkhtuvshinD enkhtuvshinD deleted the call branch February 21, 2024 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant