Improvement assets #5458
Improvement assets #5458
Conversation
|
🧙 Sourcery has finished reviewing your pull request! Tips
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 963b2bd in 1 minute and 12 seconds
More details
- Looked at
248lines of code in2files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_TgqWld30xZhyjQdo
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
⌛ 6 days left in your free trial, upgrade for $20/seat/month or contact us.
| @@ -189,3 +189,41 @@ export const generateFilter = async ( | |||
|
|
|||
| return filter; | |||
| }; | |||
|
|
|||
| export const getLasthistoryEachAssets = async ( | |||
There was a problem hiding this comment.
Consider renaming the function getLasthistoryEachAssets to follow camelCase and enhance clarity. A suggested name could be getLastHistoryForEachAsset.
|
ISSUE
Context
Your context here. Additionally, any screenshots. Delete this line.
// Delete the below section once completed
PR Checklist
Summary:
Added functionality to fetch the last history of each asset's knowledge base articles and updated code style consistency.
Key points:
consumeRPCQueueforassets:assets.getKbArticleHistoriesPerAssetinpackages/plugin-assets-api/src/messageBroker.tsgetLasthistoryEachAssetsfunction inpackages/plugin-assets-api/src/utils.tsgenerateFilterfunction inpackages/plugin-assets-api/src/utils.tsfor code style consistencyGenerated with ❤️ by ellipsis.dev