-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error: Cannot find module 'functions-have-names' -v1.5.1 #27
Comments
Same issue here. "overrides": {
"deep-equal": {
"regexp.prototype.flags": "npm:regexp.prototype.flags@1.5.0"
}
} |
Root of the problem seems to be this issue in the |
You guys have 30 million downloads per week (great job btw!) and still you published a major update of some small library without testing. Please try not to do this in the future, as your "regex" library is being used by |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Adding |
This comment was marked as spam.
This comment was marked as spam.
FYI: @ljharb SO pls try add |
This change caused our internal libraries to fail overnight because it's a dependency of a dependency of a dependency of ... We opted for the overrides solution as suggested by @regnete, which works fine!
|
We have 100s of applications failing their |
This comment was marked as spam.
This comment was marked as spam.
v2.0.1 of I'd suggest using lockfiles so this kind of thing isn't so urgent. |
We do use lockfiles, but if dependencies are defined with a This was very confusing to us because our pipeline was working fine, but a developer that had added a new dependency and fully regenerated the lockfile, suddenly had linting not working (which is unrelated to the added dependency). |
@glenstaes totally understand that, but surely that developer was thus prevented from merging their code, affecting nobody but them? |
We have a process where we let one of our pipelines build a package which is then downloaded by our workers and installed via npm. This fails, even though we do have a I do not think using a |
It would be a major bug in npm if an npm-shrinkwrap.json was not respected; please file that if that's the case, since it's worked for the entirety of npm's existence. The lockfile that would protect you is the package-lock in the project in which "installed via npm" happens. |
Sure, but if you have 6 developers at the beginning of a project, all adding dependencies and spending an hour investigating why they can't run the linting command, this easily adds up to 6 hours of budget getting lost. Add to this, a senior developer that is capable of identifying from where this issue originates and to ensure that all 6 developers are up and running again, this becomes a very costly effort, very fast. And that just for one company. With 30 million downloads per week, many companies are affected. |
Gotcha - sounds like my unpaid work is saving many companies a lot of money (most of the time). I wonder what could be done about that :-p |
Thanks for the quick response. I think I am not sound enough with the whole npm environment. We do not have a |
The workers should have lockfiles, which should be in source control and whose changes should be reviewed by developers. That way, nothing unexpected should arrive on your workers. |
@ljharb how do you handle for example a small CLI tool, which you publish as a npm package on your self-hosted GitLab and which you want to install on all your servers? For sure you commit a |
You should have a package.json and a package-lock.json on each server. or, better, that should all be one project that's tarballed into an artifact and deployed to all your servers, so that you're not doing any installations directly inside a server. |
failed to load config from /app/vite.config.ts
error during build:
Error: Cannot find module 'functions-have-names'
Require stack:
at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15)
at Function.Module._load (node:internal/modules/cjs/loader:778:27)
at Module.require (node:internal/modules/cjs/loader:1005:19)
at require (node:internal/modules/cjs/helpers:102:18)
at Object. (/app/node_modules/set-function-name/index.js:5:38)
at Module._compile (node:internal/modules/cjs/loader:1103:14)
at Module._extensions..js (node:internal/modules/cjs/loader:1157:10)
at Object._require.extensions. [as .js] (file:///app/node_modules/vite/dist/node/chunks/dep-ca21228b.js:62359:17)
at Module.load (node:internal/modules/cjs/loader:981:32)
at Function.Module._load (node:internal/modules/cjs/loader:822:12)
Build step 'Execute shell' marked build as failure
The text was updated successfully, but these errors were encountered: