Fix Object.create polyfill to accept any Object instance #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t/Reference/Global_Objects/Object/create/) accepts `instanceof Object` and `null`. For example, `Object.create(jQuery)` is totally legit. This pull fixes the polyfill to that effect. The previous typechecking insufficiently used only [typeof](https://developer.mozilla.org/en/JavaScript/Reference/Operators/typeof) `"object". Use [typeof](https://developer.mozilla.org/en/JavaScript/Reference/Operators/typeof) `"object"`|`"function"` rather than `instanceof Object` tho for tighter compatibility with the native version. See comments inline.
|
Great! =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The native Object.create accepts
instanceof Objectandnull. For example,Object.create(jQuery)is totally legit. This pull fixes the polyfill to that effect. The previous typechecking insufficiently used only typeof"object". Use typeof"object"|"function"rather thaninstanceof Objecttho for tighter effective compatibility with the native version. See comments inline.