Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import PAC193x sensor library improvements #214

Closed
2 tasks
DavidFederl opened this issue Apr 27, 2024 · 1 comment · Fixed by #225
Closed
2 tasks

Import PAC193x sensor library improvements #214

DavidFederl opened this issue Apr 27, 2024 · 1 comment · Fixed by #225
Assignees
@DavidFederl
Labels
bug Something isn't working sensor sensor library related issues

Comments

@DavidFederl
Copy link
Contributor

DavidFederl commented Apr 27, 2024 •
edited
Loading

Description

Import proposed changed from @SuperChange001 implementation inside his proposal.
The current library doesn't properly distinguish between Power and Energy measurements!

ToDo

  • Checkout differences between the proposed implementation and the current one
  • Remove unnecessary delays from library functions and add a note the corresponding documentation inside the header
@DavidFederl DavidFederl self-assigned this Apr 27, 2024
@DavidFederl DavidFederl added bug Something isn't working sensor sensor library related issues labels Apr 27, 2024
@DavidFederl DavidFederl changed the title Import PAC193x sensor library improvements from Import PAC193x sensor library improvements Apr 27, 2024
@DavidFederl
Copy link
Contributor Author

should wait for #211 to be finished first

@DavidFederl DavidFederl linked a pull request Jun 29, 2024 that will close this issue
214 import pac193x sensor library improvements #225
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DavidFederl DavidFederl

Labels
bug Something isn't working sensor sensor library related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

214 import pac193x sensor library improvements es-ude/elastic-ai.runtime.enV5
1 participant
@DavidFederl