Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] redundant code in moead.cpp #528

Closed
leonwittemund opened this issue Dec 23, 2022 · 2 comments
Closed

[BUG] redundant code in moead.cpp #528

leonwittemund opened this issue Dec 23, 2022 · 2 comments
Labels

Comments

@leonwittemund
Copy link

The report is more an improvement rather than a bug.
In moead.cpp the lines 246-248 are redundant to 249.

Screenshot 2022-12-23 113205

Both statements update the ideal point by computing the minimum of the old fitness and the new fitness values. So you should decide for one solution.

If both statements were not redundant, it would be nice to explain why they are necessary.

@bluescarni
Copy link
Member

Thanks for spotting this @leonwittemund .

I talked to @darioizzo (the original author of the code) and he agrees this was probably an oversight. I'll push him to open a PR when he comes back from vacations :)

@leonwittemund
Copy link
Author

No problem @bluescarni.
Thank you for your answer ;).

I am closing this issue because I think it will be fixed soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants