Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: download more node/edge information #6

Merged
merged 11 commits into from
Feb 5, 2021
Merged

Conversation

escaped
Copy link
Collaborator

@escaped escaped commented Feb 2, 2021

Description

Enhance the downloaded map with more data

  • ability to fetch additional edge/node tags
  • elevation
  • add junction="roundabout" to nodes

Checklist

  • Tests covering the new functionality have been added
  • Code builds clean without any errors or warnings
  • Documentation has been updated
  • Changes have been added to the CHANGELOG.md
  • You added yourself to the CONTRIBUTORS.md

@escaped escaped changed the title Feat/improve download feat: download more node/edge information Feb 2, 2021
@coveralls
Copy link

coveralls commented Feb 2, 2021

Pull Request Test Coverage Report for Build 529987022

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 48 of 50 (96.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+11.5%) to 93.247%

Changes Missing Coverage Covered Lines Changed/Added Lines %
routor/cli.py 4 5 80.0%
routor/utils/graph.py 44 45 97.78%
Files with Coverage Reduction New Missed Lines %
routor/utils/graph.py 2 94.74%
Totals Coverage Status
Change from base Build 510614421: 11.5%
Covered Lines: 316
Relevant Lines: 335

💛 - Coveralls

@escaped escaped merged commit 298f4b6 into main Feb 5, 2021
@escaped escaped deleted the feat/improve_download branch February 5, 2021 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants