Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for package name change. #45

Open
demitri opened this issue Apr 1, 2020 · 3 comments
Open

Request for package name change. #45

demitri opened this issue Apr 1, 2020 · 3 comments

Comments

@demitri
Copy link

demitri commented Apr 1, 2020

There is a name collision with this package and the "meds" package located here:

https://pypi.org/project/meds/

This is problematic for a few reasons.

  • I am unable to place "meds" in a requirements.txt file as the usual machinery will pull the package above.

  • Adding esheldon/meds to an automated build environment, e.g. Docker, is notably more complicated.

Perhaps fits_meds might be more appropriate and reflective of the functionality?

@beckermr
Copy link
Collaborator

beckermr commented Apr 1, 2020

This is on conda-forge as meds already: https://github.com/conda-forge/meds-feedstock I am skeptical this name will change. However, you may be able to specify the meds by using a git url in the requirements file per the pip/setuptools docs.

@demitri
Copy link
Author

demitri commented May 8, 2020

Assume I want to create a package that depends on esheldon/meds. I cannot tell my users "install meds from conda or from source" — I want to tell my users to pip install mypackage and nothing more. Installation alone with a custom URL does not fully solve the problem. If someone already had or mistakenly installed the other meds package, then any "import meds" looking for this one will fail, but not with an ImportError exception. If this package is to be part of the larger ecosystem, a name collision is highly problematic.

@esheldon
Copy link
Owner

esheldon commented May 15, 2020

I never intended for the meds package to be public, it was always for internal DES use. I'm actually surprised anyone else is using it.

On the other hand it is used in production for all the 1) deblending in DES 2) flux measurements in DES 3) shear measurements in DES. A 100 million dollar DOE project depends on it for most of its key projects. It just doesn't make sense to me to rename the package.

I would put the odds that a user would require this package and the other meds, which is completely unrelated and appears to be abandoned, as negligible.

Given these considerations, I don't think it makes sense to rename it. But we could perhaps make a pypi entry that is called something different, such as fits_meds, but it gets installed as meds. Again, I see very little chance that this would cause a real world collision

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants