Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mail POST to mailing list fails #2

Closed
a-tal opened this issue Nov 8, 2016 · 5 comments
Closed

mail POST to mailing list fails #2

a-tal opened this issue Nov 8, 2016 · 5 comments

Comments

@a-tal
Copy link
Contributor

a-tal commented Nov 8, 2016

using recipient_type mailing_list does not send to the mailing list id, and results in a timeout

https://sentry.tech.ccp.is/ccpgames/esi-mail/issues/129447/events/4723621/

@a-tal a-tal added the bug label Nov 8, 2016
@a-tal
Copy link
Contributor Author

a-tal commented Nov 8, 2016

It also happens with corporation and alliance

@a-tal a-tal added the esi-mail label Nov 9, 2016
@aquarhead aquarhead added the TODO label Nov 12, 2016
@ghost ghost self-assigned this Nov 23, 2016
@gitAskur
Copy link
Contributor

Taking a look on the monolith side. Figure it might be exception class UserError being raised by the mail service and not going anywhere because the actions probably do not really handle user errors as exceptions.

@joejenniges
Copy link

joejenniges commented Nov 24, 2016

Sent a mail to a valid mailing list, it appeared in my sent box; however, the "To" list was empty.
http://i.imgur.com/IIK9sdy.png

Here was the request:

{"body": "Test", "subject": "Testing", "recipients": [{"recipient_id": 145174015, "recipient_type": "mailing_list"}]}

And here was the response headers:

{
  "date": "Thu, 24 Nov 2016 18:50:24 GMT",
  "via": "1.1 google",
  "alt-svc": "clear",
  "server": "nginx",
  "access-control-allow-origin": "*",
  "strict-transport-security": "max-age=31536000",
  "access-control-allow-methods": "GET,POST,DELETE,PUT,PATCH,OPTIONS",
  "content-type": "application/json",
  "status": "201",
  "access-control-expose-headers": "Content-Type,Authorization",
  "access-control-allow-credentials": "true",
  "access-control-allow-headers": "Content-Type,Authorization",
  "content-length": "9"
}

@gitAskur
Copy link
Contributor

The fix to this should be going out tomorrow. It's exactly the issue that @GunfighterJ is describing so i'm hopeful.

@aquarhead aquarhead added In Progress and removed TODO labels Jan 5, 2017
@ghost
Copy link

ghost commented Jan 5, 2017

Looks like everyone forgot about this but some quick testing suggests that the fix went out and was successful, so I'm closing this ticket. If this is not the case just reopen it and let me know.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants