Do use an abstract class instead of an interface for the information. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…"Effective Java" for holding public constants is an abstract class with a private constructor to prevent instantiation. Since Java 5 static imports are available to avoid prefixing this information with the class name.
|
Looks fine to me, thanks :) |
eskatos
added a commit
that referenced
this pull request
Oct 3, 2012
Do use an abstract class instead of an interface for the information.
|
1.3 released, should be in central in a few hours |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not use an interface for this information, the recommended way by "Effective Java" for
holding public constants is an abstract class with a private constructor to prevent
instantiation. Since Java 5 static imports are available to avoid prefixing this
information with the class name. When you have classes implementing the interface whenever you add a constant the API will change otherwise.