Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tier List Generator Doesn't Save Second Tier List #9

Closed
gunchapred opened this issue Feb 11, 2022 · 11 comments
Closed

Tier List Generator Doesn't Save Second Tier List #9

gunchapred opened this issue Feb 11, 2022 · 11 comments

Comments

@gunchapred
Copy link

Steps To Reproduce:

Go to the tier list editor.
Make a tier list.
Click Save
Create A New Tier List that isn't in the default spot.
Click Save Again and make sure it's saved to the correct spot.
Close the page.
Go back to the page
Load the tier list that isn't in the Default spot.

Once done, you will find that the tiers are cleared, but not only are they not filled with the tier list that was thee, but the tiers renamed in the default list will not change to what they are in the new list.

Expected Outcome: If you save a tier list in a spot that isn't default, it should still be there the next time you load it up

@Eskuero
Copy link
Owner

Eskuero commented Feb 11, 2022

I can't reproduce this at all with the steps provided so we are either having different expectations or different experiences. Please upload a video following your own steps starting from a refresh of the page so I can review it better.

@gunchapred
Copy link
Author

I can't reproduce this at all with the steps provided so we are either having different expectations or different experiences. Please upload a video following your own steps starting from a refresh of the page so I can review it better.

2022-02-11_10-49-52.mp4

Attached here is a video demonstrating the bug.

@Eskuero
Copy link
Owner

Eskuero commented Feb 11, 2022

Can you do while keeping the console open to see if any errors are output when saving? You open it with Ctrl+Alt+J.
So basically:

  1. Start recording
  2. Open the console (Ctrl+Alt+J)
  3. Edit the tier and save it.
  4. Run this command in the open terminal
    localStorage.getItem('saves')
  5. Refresh the tab (there's no need to open another one)
  6. Type again the command from step 4.
  7. Try reloading it the affected tier again.

Additional question: Modifications on the "Default" tierlist are properly saved?

@gunchapred
Copy link
Author

Can you do while keeping the console open to see if any errors are output when saving? You open it with Ctrl+Alt+J. So basically:

  1. Start recording
  2. Open the console (Ctrl+Alt+J)
  3. Edit the tier and save it.
  4. Run this command in the open terminal
    localStorage.getItem('saves')
  5. Refresh the tab (there's no need to open another one)
  6. Type again the command from step 4.
  7. Try reloading it the affected tier again.

Additional question: Modifications on the "Default" tierlist are properly saved?

Yes, the default tier list loads and saves correctly. I had been using it to keep track of my merge projects for some time.

2022-02-11_14-39-25.zip

Here's the video as requested.

@Eskuero
Copy link
Owner

Eskuero commented Feb 11, 2022

What is failing is a certain function used to detect the used color before storing the new data. I can't identify why tho but I think I might have a workaround for it. Will tell you to test when it's deployed.

@gunchapred
Copy link
Author

What is failing is a certain function used to detect the used color before storing the new data. I can't identify why tho but I think I might have a workaround for it. Will tell you to test when it's deployed.

Gotcha

@Eskuero
Copy link
Owner

Eskuero commented Feb 11, 2022

Try if it works now. Make sure you refresh the webpage with Ctrl+F5 to avoid old cached code from your browser of getting in your way.

@gunchapred
Copy link
Author

Try if it works now. Make sure you refresh the webpage with Ctrl+F5 to avoid old cached code from your browser of getting in your way.

Works like a charm, thanks.

@Eskuero
Copy link
Owner

Eskuero commented Feb 12, 2022

Confirmed fixed in 8055eb24d122d249ef1a0a500fb1eda0a400e7a4

@Eskuero Eskuero closed this as completed Feb 12, 2022
@gunchapred
Copy link
Author

Confirmed fixed in 8055eb24d122d249ef1a0a500fb1eda0a400e7a4

Though I would like to an addendum here, I can only save once per refresh. Afterwards, I have to refresh the page to save the tier list again.

@gunchapred
Copy link
Author

gunchapred commented Feb 12, 2022

Actually, I don't know how it works here. Apparently, the bug only made it past my testing, and my actual attempt to use it.

image

Here's the new bug.

Edit: The bug seems to be very inconsistent as to when it appears. Still trying to figure it out.

Edit 2: I figured it out. The bug apparently occurs if you rename the tiers to be different from the default tier list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants